Replace utcnow (and fix style along the way) #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnuu
requested changes
May 27, 2024
bin/remove_it.py
Outdated
| @@ -231,7 +246,7 @@ def clean_section(pub, section, conf, is_dry_run=True): | |||
| kws[key] = int(info[key]) | |||
| except KeyError: | |||
| pass | |||
| ref_time = datetime.utcnow() - timedelta(**kws) | |||
| ref_time = dt.datetime.now(dt.UTC) - dt.timedelta(**kws) | |||
There was a problem hiding this comment.
dt.UTC is added in 3.11 so it won't work with Python 3.10 which we support. Until we drop 3.10 we should use dt.timezone.utc instead.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
- Coverage 91.28% 91.12% -0.17%
==========================================
Files 26 26
Lines 5417 5406 -11
==========================================
- Hits 4945 4926 -19
- Misses 472 480 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces usages of utcnow in trollmoves.
Ruff wasn't happy about some of the code, so style was modified accordingly.